Loomio

Define a clear git branching model

JR Jason Robinson Public Seen by 45
JR

Jason Robinson Thu 6 Sep 2012 12:04PM

Jonne, is there any reason to keep them after the merge? Personally I cannot see any. I smell a proposal :)

JH

Jonne Haß Thu 6 Sep 2012 12:44PM

Hm maybe so that you can reopen a pull request if the merge got reverted?

ST

Sean Tilley Thu 6 Sep 2012 6:02PM

While I could see potential for keeping old branches around, the problem is that they're mostly kept around indefinitely, and that creates a fair amount of clutter.

Honestly, a time limit of a few weeks to a month sounds reasonable. It's enough time to revert back a feature or bad fix, without cluttering things up too much in the long run.

JR

Jason Robinson Thu 6 Sep 2012 8:36PM

The problem is if they are not cleared straight after merging - who will clear them later? :P

ST

Sean Tilley Thu 6 Sep 2012 8:39PM

I dunno, honestly I wouldn't mind regularly pruning away branches that have been merged and inactive for more than a month.

JR

Jason Robinson Thu 6 Sep 2012 8:42PM

No harm done if some branches are not cleaned ;)

BO

Billy O'Connor Fri 7 Sep 2012 5:10PM

I just forked the project, pulled my fork, fixed a bug, git commit -a'd, git push'd, and made a pull request. Should I have forked and then branched from my fork?

JH

Jonne Haß Fri 7 Sep 2012 5:49PM

Hm well, yes, you should've followed https://github.com/diaspora/diaspora/wiki/Git-Workflow ;)
Btw. looks like we need to rework that document in 8 days

BO

Billy O'Connor Fri 7 Sep 2012 6:21PM

Well, https://github.com/diaspora/diaspora/wiki/Git-Workflow is pretty clear. :) Getting set up that way now.

G

groovehunter Fri 7 Sep 2012 8:49PM

Less clutter will come also with better communication I guess. What direction it goes, the core , the modules maybe, and so on. I.e. I get courage to delete a branch if I know my wishes are perceived in the dev community. - Just a thought, hope it was clear what I mean.

Load More