Loomio
December 6th, 2013 12:20

Notifications

Jason Robinson
Jason Robinson Public Seen by 129

OK this thing is bugging me daily so raising a thread about it.

The notifications popup that we have, why does it have to mark all the five visible comments as read when you keep it open for a few seconds? This is just really frustrating as the notifications themselves don't give any clue what the target post is, so after they are all marked read, I have to click through all of them even if they would all concern only a few posts.

Also, why just 5? I would love to have it scrollable, so I can read my notifications from the menu and they would be only marked read when I have seen the actual post in question.

This is how Facebook works and tbh it's fantastic :)

Do people like the way it is or can I make an attempt to change it?

Jelle Langbroek

Jelle Langbroek December 6th, 2013 12:30

Oh yeah! I totally agree. It would be great if the popup had more information so you don't have to click all items just to find out the next refers to the previous you've already viewed.
Scrollable is okay, but I don't miss it. When I want to see more, I just click 'view all'.

Jason Robinson

Jason Robinson December 6th, 2013 13:39

The mobile notifications actually work really well, though more information about the post in question would be great.

goob

goob December 6th, 2013 14:36

Definitely yes to the first point. It's something which bugs me as well. Marking notifications as read should happen only by hovering over or clicking on the individual notification, not en masse a few seconds after the popup pane has been opened, as happens at the moment.

As to the second, I certainly wouldn't object to the pane being scrollable, but it doesn't bother me the way it is. It's easy enough to click 'View all', and in any case I suspect that for the majority of users, it would be rare for there to be more than 5 unread notifications when they check in. I can't see a downside of making the pane scrollable, but it's not as high a priority for me as changing the behaviour of 'marked as read'.

@jellelangbroek, there is a user Javascript which appends the post title to each notification in the list. It would be great if someone could adapt this for the main Diaspora code base. See https://userscripts.org/scripts/show/164822

Jason Robinson

Jason Robinson December 6th, 2013 14:52

@goob cool userscript - would definitely prefer that way than how it is at the moment - might take a hack at it :) I've grown to dislike any kind of page modifying scripts and as diaspora is open source better just modify the code itself ;)

goob

goob December 6th, 2013 15:08

Yes, @jasonrobinson if you (or someone) can do that, it would be fantastic. I think Deus Figendi writes those add-on scripts because that's the code he's comfortable working with.

I assume he's happy for anyone to modify his code, but would be worth checking to make sure before working on it.

Seth Martin

Seth Martin December 6th, 2013 18:23

I don't think the pane needs to be scrollable but please do remove this annoying feature that marks the notifications as read.

Jason Robinson

Jason Robinson December 6th, 2013 20:19

Great that there seems to be annoyance with the automarkread thing in not just me :P

@goob I don't think it's realistic to use an external user script code for internal diaspora code as is - so no problems :) For example, looking at this piece of code, it makes extra ajax requests to fetch the post data for the notifications. Of course this would not be necessary if the data was built in for rendering.

goob

goob December 6th, 2013 21:38

Cool, I didn't know how much it would have to be adapted, or even whether you'd have to start from scratch - I just linked to it in case it gives any ways in to coding something for the main code base. I'll leave it in your capable hands!

Karthikeyan A K

Karthikeyan A K December 7th, 2013 02:46

agree with @jasonrobinson , have a scrollable notification.

goob

goob December 7th, 2013 14:16

Have just opened the notifications pane and watched what happens, and the five notifications don't quite get read as marked all en masse. Some notifications at least went from unread to read individually, as the cursor is moved around, but once one gets marked as read, the others seem to follow very quickly. So it seems the code already does recognise cursor behaviour and takes each notification as separate, but perhaps the amount of time the cursor needs to be left over each notification before it gets marked as read needs to be increased.

Flaburgan

Flaburgan December 7th, 2013 17:14

I think the most important point is to mark as read notifications when we open a post in the single post view. Even if the user doesn't touch to the notification panel or page.

Jason Robinson

Jason Robinson started a proposal March 19th, 2014 10:05

What should be default when fixing #4810? Closed 12:07pm - Saturday 29 Mar 2014

Outcome
by Jason Robinson April 25th, 2017 05:15

If #4810 functionality is merged in - the NEW functionality should be default in the user settings.

There is a fix for the notifications being marked read when the notifications menu is opened that already has working code. Due to feedback, there will be a user setting made to control whether the notifications should be marked as read without actually reading them.

In other words, this setting will control whether to have it work like it works now (notifications are marked read 2s after opening the notifications dropdown) - or not mark them read automatically at all, unless user visits post/action in question.

This vote is ONLY about this setting and ONLY about which should be default - current behaviour or new behaviour.

Vote;
YES - if you want to keep the current behaviour as default
NO - if you want the new behaviour to be default

The github issue is here: https://github.com/diaspora/diaspora/pull/4810

Results
Agree - 0
Abstain - 3
Disagree - 23
Block - 0
26 people have voted (0%)
DU

[deactivated account]
Disagree
March 19th, 2014 10:10

I'm with the OP - this is SO annoying. Marking them as read after just a few secs is really frustrating. I voted NO (as per proposal details) so we can hopefully get this fixed as I'd love the NEW behaviour!

M

morgenstern
Agree
March 19th, 2014 10:20

I think the current behaviour is more intuitive for a new user so i think it should be the default one,

Steffen van Bergerem

Steffen van Bergerem
Disagree
March 19th, 2014 10:23

M

morgenstern
Agree
March 19th, 2014 10:35

I think the current behaviour is more intuitive for a new user so i think it should be the default one.

goob

goob March 19th, 2014 11:17

I read Ruxton's comment as warning against making a change which might break code/functionality for users. If this is not a danger/possibility, I would be happy to see the notification behaviour changed. But I'd like that clarified before voting.

goob

goob March 19th, 2014 11:19

@morgenstern you can see a preview of how this would work in @steffenvanbergerem's video here: http://videobin.org/+7h1/9s2.html

I think that's quite intuitive.

Steffen van Bergerem

Steffen van Bergerem March 19th, 2014 11:42

@goob The code I used for the video has not been pushed to the branch and I think I lost the code. However, rewriting that shouldn't be a lot of work.

A

Adrenalin
Disagree
March 19th, 2014 12:33

I'd like to get them not marked read automatically

Jason Robinson

Jason Robinson March 19th, 2014 12:52

I read Ruxton’s comment as warning against making a change which might break code/functionality for users. If this is not a danger/possibility, I would be happy to see the notification behaviour changed. But I’d like that clarified before voting.

I think Ruxton meant was not break code, but change functionality. YES keeps current functionality as default, NO changes it.

Jason Robinson

Jason Robinson
Disagree
March 19th, 2014 12:53

I really think it's a bug that notifications are marked read automatically. I would like new users to have less bugs ;)

goob

goob March 19th, 2014 13:41

@steffenvanbergerem Oh, thanks for the clarification. I thought your video was to show me that this is how your PR will work if implemented. I could only vote for a change of functionality if it worked in the way shown in the video. If you could please clarify whether or not the functionality shown in your video would be implemented with your PR, that would help me decide how to vote on this proposal.

goob

goob March 19th, 2014 14:01

When I say ‘like in the video’ I mean that there needs to be a means of marking individual notifications as read in the notifications drop-down itself without clicking on a notification to be taken to that post or clicking ‘view all’ to go to the notifications page.

If this were the case, I don't think we'd need to build an option to choose between this and the current system - just change it to work in this way (which is far better, I think).

PG

Paul Greindl
Disagree
March 19th, 2014 16:20

Steffen van Bergerem

Steffen van Bergerem March 19th, 2014 17:33

@goob I won't be able to add the user setting so I won't be able to finish my PR. Right now you can click on the notification and you won't be taken to that post. This is only the case when you click on the "post" link.

I can work on my PR again and create a similar user experience to the one you see in the video. However, like I said we still need someone to finish the PR.

Seth Martin

Seth Martin
Disagree
March 19th, 2014 18:18

StarBlessed

StarBlessed
Disagree
March 19th, 2014 21:19

J

jonsger
Disagree
March 19th, 2014 21:26

I don't like this automatic read "feature" so lets set the new as default

Maciek Łoziński

Maciek Łoziński
Disagree
March 20th, 2014 08:49

Flaburgan

Flaburgan March 20th, 2014 11:37

Automatic is bad, but mark as read every notification one by one is not nice. We should improve the system by auto mark as read every notifications related to a post when it is open in the SPV.

M

morgenstern
Disagree
March 20th, 2014 19:53

If the new proposal is the one shown in the video t seems fine to me to have it as default.

M

morgenstern
Disagree
March 20th, 2014 19:54

If the new proposal is the one shown in the video it seems fine to me to have it as default.

M

morgenstern March 20th, 2014 19:56

If i can something else; another small improvement to notification would be the pop-up to show the last 5 UNREAD notifications instead of the last 5 notifications.

This would allow to check one by one all the notifications without having to go to the notifications page.

goob

goob March 20th, 2014 21:21

@morgenstern I'm still waiting for confirmation from @steffenvanbergerem as to whether the functionality shown in the video will be included in this PR. I thought it was, but apparently it is not (yet) part of it. Apologies for the confusion.

goob

goob
Agree
March 20th, 2014 21:23

I have to vote to keep current functionality until I hear that http://videobin.org/+7h1/9s2.html will be implemented as part of this PR.

Steffen van Bergerem

Steffen van Bergerem March 20th, 2014 21:30

@goob

I can work on my PR again and create a similar user experience to the one you see in the video. However, like I said we still need someone to finish the PR.

Again: I am not the one who will finish this PR so I am not able to promise anything. As soon as there is someone who would like to finish the PR I will volunteer to help getting that functionality you see in the video.

Rasmus Fuhse

Rasmus Fuhse
Disagree
March 21st, 2014 05:34

The current behavior is unintuitive, I think.

DU

[deactivated account]
Disagree
March 21st, 2014 11:04

goob

goob March 21st, 2014 12:40

Again: I am not the one who will finish this PR so I am not able to promise anything. As soon as there is someone who would like to finish the PR I will volunteer to help getting that functionality you see in the video.

@steffenvanbergerem if you could add the video functionality to the PR now, before it it taken up by someone else, that would, I think, be enormously useful. Then the other person would only need to add a user setting, and the full functionality should survive into the final merged code. Would you be happy to do that?

goob

goob March 21st, 2014 12:41

Would it be useful to make a post about this from the diaspora* HQ account to get some wider feedback?

Jason Robinson

Jason Robinson March 21st, 2014 19:49

@flaburgan it already works this way

Jason Robinson

Jason Robinson March 21st, 2014 19:52

@goob we are not voting on changing anything else than what should be the default way if the PR is merged in (once someone adds user settings to it). What is it that is not clear about the functionality? In any case, no functionality will be removed.

If we make the new way default it will also be consistent with the mobile page since that is how it has always worked there. Also the "mark as unread" now actually works, since it doesn't get marked read again. Having this on my pod for a while now I can say the notifications are so much more useful now.

Steffen van Bergerem

Steffen van Bergerem March 22nd, 2014 02:13

@goob I implemented that functionality with some additional improvements in a new PR.

goob

goob March 22nd, 2014 12:49

Thanks a lot, @steffenvanbergerem. With that, I'm happy for the auto-mark-as-read to be removed.

goob

goob
Disagree
March 22nd, 2014 12:51

With https://github.com/diaspora/diaspora/pull/4869 implemented, the auto-mark-as-read won't be needed.

Ivan Gabriel Morén

Ivan Gabriel Morén
Disagree
March 22nd, 2014 15:06

Jason Robinson

Jason Robinson March 22nd, 2014 15:36

@goob it will not be removed - it will be available via user settings if NO passes here. If we want to remove it - we should vote separately.

SuperTux88

SuperTux88
Disagree
March 23rd, 2014 17:32

thomas

thomas
Agree
March 23rd, 2014 18:21

thomas

thomas
Abstain
March 23rd, 2014 18:22

theradialactive

theradialactive
Abstain
March 25th, 2014 18:39

Ryuno-Ki

Ryuno-Ki
Disagree
March 26th, 2014 09:19

It annoys me to see plopping the notifications to "read" status before I got to it. Moreover, it doesn't work in the "Show all notifications" stream!

DU

[deactivated account]
Disagree
March 26th, 2014 16:26

Since my first day on Diaspora this has been the most annoying thing.

It would be great if there was a small extract of the Post, too, so you can quickly recognize which notification belongs to which post.

Mike Powell

Mike Powell
Disagree
March 26th, 2014 23:54

Steffen van Bergerem

Steffen van Bergerem March 27th, 2014 00:23

@thomasl That has already been implemented and will be available on your pod after the next update.

DU

[deactivated account] March 27th, 2014 15:03

yaaay \o/ :)

Dee Baumdeesaster

Dee Baumdeesaster
Disagree
March 28th, 2014 09:08

L

lebarjack
Disagree
March 28th, 2014 12:44

Flaburgan

Flaburgan
Abstain
March 28th, 2014 12:57

Flaburgan

Flaburgan March 28th, 2014 13:02

Flaburgan said:

We should improve the system by auto mark as read every notifications related to a post when it is open in the SPV.

Jason said:

@flaburgan it already works this way

@jasonrobinson no it doesn't. I open my notifications using the link in the e-mail, and my notifications counter doesn't go down. You can make the test easily, when you receive a email about a notification, check on diaspora how many unread notifications you have in the header, click on the link in the email and check again the unread notifications in the header, and you will see that it is the same number.

Marek Marecki

Marek Marecki
Disagree
March 28th, 2014 21:39

Jelle Langbroek

Jelle Langbroek
Disagree
March 28th, 2014 23:32

ventos

ventos
Disagree
March 29th, 2014 05:18

Jason Robinson

Jason Robinson March 29th, 2014 07:12

@fla

Jason Robinson

Jason Robinson March 29th, 2014 07:13

@flaburgan that sounds like a separate bug - I'm quite sure when clicking a post notification from the notifications menu it marks all notifications as read related to this post. I'm actually very certain. If it doesn't work that way when coming from emails then it's a bug :)

Jason Robinson

Jason Robinson started a proposal March 29th, 2014 19:17

Change notification dropdown functionality without user settings Closed 10:07pm - Saturday 12 Apr 2014

Outcome
by Jason Robinson April 25th, 2017 05:15

We remove the “automatically mark notifications as read after 2 seconds when opening the notifications dropdown in desktop mode”. This small code change is already in pull request #4810 (https://github.com/diaspora/diaspora/pull/4810 ).

As the vote to change the default way the notifications dropdown would work was quite decisive (in favour of new functionality) - I'm making a follow up poll to implement the NEW functionality without keeping the old one available in user settings.

There are many good reasons to do this;

  • The old functionality is inconsistent. Notifications are not automatically marked read in the mobile view or when viewing all notifications. Why then when opening the dropdown?
  • We should not let diaspora* end up in a user settings chaos where there are hundreds of options to confuse new users
  • We should be simplifying the code, not creating logic to keep old functionality

Thus my proposal, vote as follows;

YES - We remove the "automatically mark notifications as read after 2 seconds when opening the notifications dropdown in desktop mode". This small code change is already in pull request #4810 (https://github.com/diaspora/diaspora/pull/4810 ).

NO - Make the change, but keep the old functionality available via user settings.

Results
Agree - 20
Abstain - 0
Disagree - 1
Block - 0
21 people have voted (0%)
Jason Robinson

Jason Robinson
Agree
March 29th, 2014 19:18

SuperTux88

SuperTux88
Agree
March 29th, 2014 19:20

Jelle Langbroek

Jelle Langbroek
Agree
March 29th, 2014 19:47

ventos

ventos
Agree
March 29th, 2014 21:14

DU

[deactivated account]
Agree
March 29th, 2014 21:29

Is it ready yet?

Seth Martin

Seth Martin
Agree
March 30th, 2014 03:44

Jason Robinson

Jason Robinson March 30th, 2014 08:47

@rich1 it's only a few lines of javascript to remove from the code. Bringing in a new user setting would be extra code to maintain.

DU

[deactivated account]
Agree
March 30th, 2014 11:42

Ivan Gabriel Morén

Ivan Gabriel Morén
Agree
March 30th, 2014 13:57

Ryuno-Ki

Ryuno-Ki
Agree
March 31st, 2014 20:08

Vostok

Vostok
Agree
March 31st, 2014 21:10

Florian Staudacher

Florian Staudacher
Agree
April 1st, 2014 18:18

Q

Quetschwalze
Agree
April 4th, 2014 07:07

PG

Paul Greindl
Agree
April 5th, 2014 15:43

Rasmus Fuhse

Rasmus Fuhse
Agree
April 6th, 2014 11:32

R

rhaglion
Agree
April 6th, 2014 19:53

L

lebarjack
Agree
April 8th, 2014 09:52

theradialactive

theradialactive
Disagree
April 8th, 2014 13:44

A

Adrenalin
Agree
April 10th, 2014 08:39

Maciek Łoziński

Maciek Łoziński
Agree
April 11th, 2014 06:25

Karthikeyan A K

Karthikeyan A K
Agree
April 12th, 2014 04:09

DU

[deactivated account]
Agree
April 12th, 2014 16:23