New header design
Whil porting the header to Bootstrap, I've made some few design changes to make it consistant with the rest of the new design. This proposition is about adopting these few design changes.
Here is a comparison of what it looked before and how it look right now :
and here is how it looks now :
The key design changes are :
- no more shadow at the bottom of the header,
- the searchbar is higher and squared like the bootstrap's button are,
- the notifications dropdown is bigger, each notification has more padding, the profile pictures are bigger to improve readability,
- the user menu is now white with blue links.
Deleted account Thu 26 Mar 2015 7:32AM
Just want to add that the font-size for the username in the header is bigger than before
No, it' not. It's 13px. The padding is bigger, yes, but not the font size. About .form-search, I didn't used it as this class seems to be deprecated in BS3 and I wrote BS3 code only an not BS2. This is why I'm not using it. Though, I can use it here knowing you will have to change it back when porting it to BS3.
Appart from that, it seems like the main design concerns are the white menu and the grey hover buttons effects ?
Steffen van Bergerem Thu 26 Mar 2015 11:37AM
No, it' not. It’s 13px.
The Firefox inspector tells me that it is 14px.
it seems like the main design concerns are the white menu and the grey hover buttons effects
At least for me there is also the notification dropdown with bigger avatars, bigger margins, a blue background for the hovered "mark all as read" link and the CSS gradient for those backgrounds instead of using one color. These are all design changes that I don't like.
Deleted account Thu 26 Mar 2015 9:55PM
The Firefox inspector tells me that it is 14px.
Oh ? This is weird :/
This is a bug, I'll fix that.
At least for me there is also the notification dropdown with bigger avatars, bigger margins, a blue background for the hovered “mark all as read” link and the CSS gradient for those backgrounds instead of using one color. These are all design changes that I don’t like.
Short story long, you don't like anything ? :(
I find the bigger margin makes the dropdown really more easy to read, don't you ?
Though, I admit that the right margin of the avatars are a bit large.
Dennis Schubert Fri 27 Mar 2015 12:16AM
Ok, just explaining you how I use IRC so you can understand why I can’t just check the logs [...] That’s why I asked you to express them on github and be clear. ;)
I see. However, I don't get why you cannot remember points raised during discussions you did participate. Anyway, I checked the logs, tested the PR myself and talked with Steffen to create this list:
https://github.com/diaspora/diaspora/pull/5480#issuecomment-86767145
Note that these points are not related to the design itself, these are way more general issues.
Deleted account Fri 27 Mar 2015 9:04AM
@dennisschubert and @steffenvanbergerem : Thank you very much for the very previse feedback. I'm going back to work.
Dennis Schubert Thu 2 Apr 2015 8:53PM
Since Augier is not willing to finish the work, we have nothing left to discuss about. 0.5.0.0 is about to get released and Bootstrap 3 will be used in the future.
Blocking this proposal since we would not be able to able to implement the changes right now. Another vote shall be started as soon as we started working on Bootstrap 3.
Jason Robinson Sun 5 Apr 2015 12:21PM
I used magnificent admin powers to close the vote since Augier decided not to work on the PR :( @augier if you feel like reopening that, or at least indicate you want to continue working on it at some point, lets reopen the vote.
Theatre-X Sun 5 Apr 2015 12:31PM
Looks a lot better man!
Abdul Raheem Thu 9 Jun 2016 10:09AM
I want this design from where I can get this?
Steffen van Bergerem · Thu 26 Mar 2015 12:36AM
@dennisschubert and @jhass already mentioned a lot of problems which I also see with your proposed design. Just want to add that the font-size for the username in the header is bigger than before and I think the old version was better.