Loomio
Sun 28 Dec 2014 3:57PM

High resolution / full sized images for lightbox

DU Thomas Leister Public Seen by 157

Hi @all,

Since my first day on Diaspora I have wondered why images displayed in the lightbox are so small. They do not differ much from the in-stream version and sometimes it's hard to see the tiny parts of a picture.

To get a full-sized version of the image there is a little trick: You take the image URL and remove the "scaled_full" in front of the image filename, paste it in your address bar again and you get the original image file.

This trick is not well-known and I guess some users have difficulties to enlarge pictures.

My idea is to show a full-sized version (original version) of the image in the lightbox instead of the smaller scaled_full version. There is more than enough space to give images the space they need. We will keep having the scaled_full version in the stream as small footprint preview, but if you open the lightbox on that picture you will get the full version on your screen.

To prevent parts of the image being cut off due to small screen size, the lightbox will resize the full version to a size which fits the screen in width. This will happen dynamically and CSS-based.

There's a short screencast on my server to show my finished work: https://cloud.trashserver.net/public.php?service=files&t=1229224ef4da202a4c58160200008e8a

In my current code there is only a small border around the image. You can easily increase the border width if you want, but that's more detailed stuff we can discuss about later.

My updated code for Diaspora is finished so far. You can see the changes here: https://github.com/ThomasLeister/diaspora/compare/bigpics?expand=1

Let me know if you like the changes. If you do, we can easily merge my code to the Diaspora dev branch and have full-sized images in the next Diaspora* release :)

Update: Pull request on GitHib: https://github.com/diaspora/diaspora/pull/5500

Update2: Video on YouTube: https://www.youtube.com/watch?v=YMsm9MVl1T0

DU

Poll Created Sun 28 Dec 2014 4:05PM

Should Diaspora* have a full-size image lightbox? Closed Wed 14 Jan 2015 10:04PM

Agree: I like that! Merge this feature into diaspora-develop

Disagree: I don't like your idea.

Results

Results Option % of points Voters
Agree 91.7% 33 M R R TS M KAK PS JS A C DU Q G A GK DL TR L JL Y
Abstain 2.8% 1 JR
Disagree 5.6% 2 JH MB
Block 0.0% 0  
Undecided 0% 250 BK ST FS MS TS AA S CB HF BO DM GC JH F RF M EG G AX PC

36 of 286 people have participated (12%)

R

rhaglion
Agree
Sun 28 Dec 2014 4:20PM

Finally, it's here. I think @Thomas Leister already mentioned why this is would be a good improvement.

C

Camil
Agree
Sun 28 Dec 2014 4:46PM

Great job, many honest thanks for your work!

AF

Alexander Finkhäuser
Agree
Sun 28 Dec 2014 5:03PM

nice ;)

JH

Jonne Haß
Disagree
Sun 28 Dec 2014 5:10PM

I think this needs further discussion before going into the voting phase, see https://github.com/diaspora/diaspora/pull/5500#issuecomment-68212836

KAK

Karthikeyan A K
Agree
Sun 28 Dec 2014 5:23PM

Great!

R

rhaglion
Agree
Sun 28 Dec 2014 10:59PM

I think @Thomas Leister already mentioned why this would be a good improvement.

S

sassonie
Agree
Tue 30 Dec 2014 9:55PM

I'm a photography lover and I like to see pictures in a nice resolution. And the original sized picture is already uploaded so why not show it to us?

DL

Dani'el Levity
Agree
Tue 30 Dec 2014 11:49PM

Resizable images directly in the stream would be awesome, too.. i have a tendency to attempt this, constantly, being a reddit RES user which does this.

LM

Lucas Meijer
Agree
Fri 2 Jan 2015 6:48PM

This is an excellent proposition which adds a lot of polish to the site!

Load More