Search
James McCann
Public
Seen by 24
Attached mockup of how the search bar might fit into the context of the dashboard.
https://docs.google.com/open?id=0B4_HCol896iTOFVycmp1QXBoNFE
Think it would be appropriate for this to be able to filter automatically by what group you are currently viewing but the results page should allow you to remove this filter and show all group results.
(Results page mockup coming soon)
James McCann Fri 18 Jan 2013 8:35AM
It might be a slightly different bug? Unless its been fixed and waiting to be deployed?
I've got a pull request here https://github.com/enspiral/loomio/pull/449 that should fix this along with the double up for a new comment/mentioned notification bug - both on this card https://trello.com/card/new-comment-and-mentioned-you-in-a-comment-notifications-should-be-collapsed-into-one/4fc418d7b528e7e2398311b4/359
Aaron Thornton Fri 18 Jan 2013 7:30PM
My bad. At least we have it covered now.
Richard D. Bartlett Wed 30 Jan 2013 10:42PM
Can anyone tell me the progress on this feature? @jamesmccann @jonlemmon
James McCann Wed 30 Jan 2013 10:54PM
See here https://github.com/jamesmccann/loomio/tree/feature/filter-search
Sorry I mentioned Jon in this branch to comment on it but he might not get notifications from my repo? I should have pull requested it.
Anyway, I've refactored as per me and Jon's sit down the other day. If Jon has a look and gets back to me with his thoughts/check over what I've done with the DiscussionsQuery so far then I can finish this off.
Jon Lemmon Wed 30 Jan 2013 11:48PM
@jamesmccann I think I might have responded to your at-mention. Are you talking about this one?
https://github.com/jamesmccann/loomio/commit/6f908013e832f25c9db21c68f297c47f1ede4328
Sorry, I should have double-checked to see that you got my message. Github notifications seem to be a bit strange sometimes.
=)
James McCann Mon 4 Feb 2013 3:04AM
@jonlemmon true! Weird I didn't see any Github or Loomio notifications in my email. My bad. I'll suss this one out asap
Jon Lemmon Wed 6 Feb 2013 9:56AM
@jamesmccann no worries. I find GH notifications a bit hard to keep track of myself.
James McCann Thu 7 Feb 2013 8:51PM
@jonlemmon yeah not the best eh. Finally got some internet at my new flat so I'll sort this over this coming weekend!
Jon Lemmon Thu 7 Feb 2013 8:54PM
@jamesmccann rad. I'll be away for the weekend but will have a look when I'm back on Monday or Tuesday.
Jon Lemmon · Thu 17 Jan 2013 6:57AM
@aaronthornton are you sure? this is a slightly different one. it's if a user get's mentioned twice in one comment.
i'm pretty sure that the bug you fixed was a user getting notified twice when they get mentioned once in a comment.